Skip to content

Commit

Permalink
ci: fix jest/cypress clash that broke eslint locally
Browse files Browse the repository at this point in the history
  • Loading branch information
acao committed Nov 20, 2019
1 parent 4de9408 commit 1538a0c
Show file tree
Hide file tree
Showing 11 changed files with 58 additions and 22 deletions.
20 changes: 14 additions & 6 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
* This source code is licensed under the license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
*/

module.exports = {
Expand All @@ -21,9 +20,9 @@ module.exports = {
},
},
settings: {
'react': {
'version': 'detect'
}
react: {
version: 'detect',
},
},
// https://github.com/sindresorhus/globals/blob/master/globals.json
env: {
Expand All @@ -33,7 +32,6 @@ module.exports = {
jest: true,
mocha: true,
browser: true,
'cypress/globals': true
},

extends: ['prettier', 'plugin:import/typescript', 'plugin:react/recommended'],
Expand Down Expand Up @@ -292,9 +290,19 @@ module.exports = {
'prefer-object-spread/prefer-object-spread': 1,
},

plugins: ['babel', 'import', 'flowtype', 'prefer-object-spread', 'cypress'],
plugins: ['babel', 'import', 'flowtype', 'prefer-object-spread'],

overrides: [
// Cypress plugin, global, etc only for cypress directory
// https://github.com/cypress-io/eslint-plugin-cypress
// cypress clashes with jest expect()
{
files: ['**/cypress/**'],
plugins: ['cypress'],
env: {
'cypress/globals': true,
},
},
// Rules for TypeScript only
{
files: ['*.ts', '*.tsx'],
Expand Down
4 changes: 0 additions & 4 deletions packages/codemirror-graphql/.npmignore

This file was deleted.

18 changes: 15 additions & 3 deletions packages/codemirror-graphql/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,21 @@
},
"license": "MIT",
"files": [
"esm",
"*.js",
"*.flow",
"hint.esm.js",
"hint.js",
"hint.js.flow",
"info.esm.js",
"info.js",
"info.js.flow",
"jump.esm.js",
"jump.js",
"jump.js.flow",
"lint.esm.js",
"lint.js",
"lint.js.flow",
"mode.esm.js",
"mode.js",
"mode.js.flow",
"utils",
"variables",
"results"
Expand Down
1 change: 0 additions & 1 deletion packages/graphiql/.babelrc.js

This file was deleted.

2 changes: 1 addition & 1 deletion packages/graphiql/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"build-demo": "cp resources/index.html .",
"check": "flow check",
"dev": "babel-node test/server.js",
"e2e": "yarn e2e:server && cypress run && kill -9 `cat test/pid`",
"e2e": "yarn e2e:server && cypress run",
"e2e:server": "PORT=8080 node test/e2e-server & wait-on http://localhost:8080",
"test": "node ../../resources/runTests ENZYME=true"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/graphql-language-service-types/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
],
"main": "dist/index.js",
"module": "esm/index.js",
"typings": "src/index.ts",
"typings": "dist/index.d.ts",
"scripts": {
"build": "yarn run build-ts && yarn run build-flow",
"build-ts": "tsc",
Expand Down
6 changes: 4 additions & 2 deletions packages/graphql-language-service-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
},
"license": "MIT",
"files": [
"dist",
"esm"
"dist"
],
"keywords": [
"graphql"
Expand All @@ -40,5 +39,8 @@
"dependencies": {
"graphql-config": "2.2.1",
"graphql-language-service-types": "^1.5.0"
},
"devDependencies": {
"@types/jest": "^24.0.23"
}
}
4 changes: 3 additions & 1 deletion packages/graphql-language-service-utils/src/file.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ describe('requireFile', () => {
);
});
it('should require file with no extension using js', async () => {
const config = await requireFile(path.join(__dirname, '../../../jest.config'));
const config = await requireFile(
path.join(__dirname, '../../../jest.config'),
);
await expect(config.collectCoverage).toEqual(true);
});
it('should require file with no extension using json', async () => {
Expand Down
7 changes: 6 additions & 1 deletion packages/graphql-language-service-utils/tsconfig.esm.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,10 @@
"compilerOptions": {
"rootDir": "./src",
"outDir": "./esm",
}
},
"references": [
{
"path": "../graphql-language-service-types"
}
]
}
7 changes: 6 additions & 1 deletion packages/graphql-language-service-utils/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,10 @@
"compilerOptions": {
"rootDir": "./src",
"outDir": "./dist",
}
},
"references": [
{
"path": "../graphql-language-service-types"
}
]
}
9 changes: 8 additions & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2556,6 +2556,13 @@
dependencies:
"@types/jest-diff" "*"

"@types/jest@^24.0.23":
version "24.0.23"
resolved "https://registry.npmjs.org/@types/jest/-/jest-24.0.23.tgz#046f8e2ade026fe831623e361a36b6fb9a4463e4"
integrity sha512-L7MBvwfNpe7yVPTXLn32df/EK+AMBFAFvZrRuArGs7npEWnlziUXK+5GMIUTI4NIuwok3XibsjXCs5HxviYXjg==
dependencies:
jest-diff "^24.3.0"

"@types/json-schema@^7.0.3":
version "7.0.3"
resolved "https://registry.yarnpkg.com/@types/json-schema/-/json-schema-7.0.3.tgz#bdfd69d61e464dcc81b25159c270d75a73c1a636"
Expand Down Expand Up @@ -8325,7 +8332,7 @@ jest-config@^24.9.0:
pretty-format "^24.9.0"
realpath-native "^1.1.0"

jest-diff@^24.9.0:
jest-diff@^24.3.0, jest-diff@^24.9.0:
version "24.9.0"
resolved "https://registry.npmjs.org/jest-diff/-/jest-diff-24.9.0.tgz#931b7d0d5778a1baf7452cb816e325e3724055da"
integrity sha512-qMfrTs8AdJE2iqrTp0hzh7kTd2PQWrsFyj9tORoKmu32xjPjeE4NyjVRDz8ybYwqS2ik8N4hsIpiVTyFeo2lBQ==
Expand Down

0 comments on commit 1538a0c

Please sign in to comment.