chore: fail netlify, consolidate graphiql webpack examples (#2024)

graphql · Nov 13, 2021 · 25fb5c5 · 25fb5c5 · github-actions · Nov 13, 2021
1 parent 0d3ff90
commit 25fb5c5
Show file tree

Hide file tree

Showing 12 changed files with 19 additions and 174 deletions.
diff --git a/.github/workflows/deploy-preview.yml b/.github/workflows/deploy-preview.yml
@@ -35,9 +35,10 @@ jobs:
           enable-commit-comment: true
           overwrites-pull-request-comment: true
           functions-dir: functions
-          github-deployment-environment: "graphiql-1"
+          github-deployment-environment: "graphiql-cdn-preview"
+          fails-without-credentials: true
         env:
-          NETLIFY_AUTH_TOKEN: ${{ secrets.AUTH_TOKEN }}
+          NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
           NETLIFY_SITE_ID: ${{ secrets.SITE_ID }}
         timeout-minutes: 1
   # monaco-graphql deploy preview
@@ -60,14 +61,15 @@ jobs:
       - name: Deploy Monaco GraphQL Example to Netlify
         uses: nwtgck/actions-netlify@v1.2
         with:
-          publish-dir: './examples/monaco-graphql-webpack/bundle'
+          publish-dir: './examples/monaco-graphql-webpack/dist'
           production-branch: main
           github-token: ${{ secrets.GITHUB_TOKEN }}
-          deploy-message: "Monaco GraphQL Preview"
-          functions-dir: functions
-          github-deployment-environment: "monaco-graphql"
+          deploy-message: "Monaco GraphQL Webpack Preview"
+          github-deployment-environment: "monaco-graphql-webpack-preview"
+          github-deployment-description: "A vanilla js github explorer example of `monaco-graphql` using webpack"
+          fails-without-credentials: true
         env:
-          NETLIFY_AUTH_TOKEN: ${{ secrets.AUTH_TOKEN }}
+          NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
           NETLIFY_SITE_ID: 46a6b3c8-992f-4623-9a76-f1bd5d40505c
         timeout-minutes: 1
   # Test the webpack + typescript + react consuming build
@@ -84,19 +86,20 @@ jobs:
       - name: Build 
         run: yarn build & yarn build-bundles
 
-      - name: Build Webpack Example 
+      - name: Build GraphiQL Webpack Example 
         run: yarn workspace example-graphiql-webpack run build-demo
 
-      - name: Deploy Webpack Example to Netlify
+      - name: Deploy GraphiQL Webpack Example to Netlify
         uses: nwtgck/actions-netlify@v1.2
         with:
           publish-dir: './examples/graphiql-webpack/dist'
           production-branch: main
           github-token: ${{ secrets.GITHUB_TOKEN }}
           deploy-message: "GraphiQL Webpack Example"
           functions-dir: functions
-          github-deployment-environment: "graphiql-webpack"
+          github-deployment-environment: "graphiql-webpack-preview"
+          fails-without-credentials: true
         env:
-          NETLIFY_AUTH_TOKEN: ${{ secrets.AUTH_TOKEN }}
+          NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
           NETLIFY_SITE_ID: aabca80b-fe63-43df-83ef-e431876560c9
         timeout-minutes: 1
diff --git a/examples/graphiql-cdn-create-fetcher/README.md b/examples/graphiql-cdn-create-fetcher/README.md
diff --git a/examples/graphiql-cdn-create-fetcher/index.html b/examples/graphiql-cdn-create-fetcher/index.html
diff --git a/examples/graphiql-cdn-create-fetcher/package.json b/examples/graphiql-cdn-create-fetcher/package.json
diff --git a/examples/graphiql-create-fetcher/README.md b/examples/graphiql-create-fetcher/README.md
diff --git a/examples/graphiql-create-fetcher/babel.config.js b/examples/graphiql-create-fetcher/babel.config.js
diff --git a/examples/graphiql-create-fetcher/package.json b/examples/graphiql-create-fetcher/package.json
diff --git a/examples/graphiql-create-fetcher/src/index.html.ejs b/examples/graphiql-create-fetcher/src/index.html.ejs
diff --git a/examples/graphiql-create-fetcher/webpack.config.js b/examples/graphiql-create-fetcher/webpack.config.js
diff --git a/examples/graphiql-webpack/package.json b/examples/graphiql-webpack/package.json
@@ -10,6 +10,7 @@
   },
   "dependencies": {
     "graphiql": "file:../../packages/graphiql",
+    "@graphiql/toolkit": "file:../../packages/graphiql-toolkit",
     "graphql": "16.0.0-experimental-stream-defer.5",
     "react": "17.0.2"
   },

diff --git a/examples/monaco-graphql-webpack/src/index.html.ejs b/examples/monaco-graphql-webpack/src/index.html.ejs
@@ -31,9 +31,8 @@
         padding: .5em 1em;
       }
     </style>
-    <script src="https://unpkg.com/netlify-auth-providers"></script>
+
   </head>
-
   <body style="margin: 0; padding: 0;">
     <div style="display: flex;">
       <div class="full-height column">
@@ -49,5 +48,7 @@
         aria-atomic="true"
       ></div>
     </div>
+    <!-- for github auth -->
+    <script src="https://unpkg.com/netlify-auth-providers"></script>
   </body>
 </html>
diff --git a/examples/monaco-graphql-webpack/webpack.config.js b/examples/monaco-graphql-webpack/webpack.config.js
@@ -14,7 +14,7 @@ const resultConfig = {
   entry: './index.ts',
   context: rootPath('src'),
   output: {
-    path: rootPath('bundle'),
+    path: rootPath('dist'),
     filename: '[name].js',
     globalObject: 'self',
   },