fix: LSP server crashing in case of error in schema

- Added try-catch block around handleWatchedFilesChangedNotification handler to prevent server crash on schema update.
graphql · Nov 20, 2023 · 5910332 · 5910332
1 parent 0c64305
commit 5910332
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 34 deletions.
diff --git a/.changeset/lovely-steaks-knock.md b/.changeset/lovely-steaks-knock.md
@@ -0,0 +1,5 @@
+---
+'graphql-language-service-server': patch
+---
+
+Fixed crashing of LSP server on saving a schema with errors
diff --git a/packages/graphql-language-service-server/src/MessageProcessor.ts b/packages/graphql-language-service-server/src/MessageProcessor.ts
@@ -664,42 +664,47 @@ export class MessageProcessor {
           await this._updateFragmentDefinition(uri, contents);
           await this._updateObjectTypeDefinition(uri, contents);
 
-          const project = this._graphQLCache.getProjectForFile(uri);
-          if (project) {
-            await this._updateSchemaIfChanged(project, uri);
-          }
+          try {
+            const project = this._graphQLCache.getProjectForFile(uri);
+            if (project) {
+              await this._updateSchemaIfChanged(project, uri);
+            }
 
-          let diagnostics: Diagnostic[] = [];
-
-          if (
-            project?.extensions?.languageService?.enableValidation !== false
-          ) {
-            diagnostics = (
-              await Promise.all(
-                contents.map(async ({ query, range }) => {
-                  const results = await this._languageService.getDiagnostics(
-                    query,
-                    uri,
-                    this._isRelayCompatMode(query),
-                  );
-                  if (results && results.length > 0) {
-                    return processDiagnosticsMessage(results, query, range);
-                  }
-                  return [];
-                }),
-              )
-            ).reduce((left, right) => left.concat(right), diagnostics);
-          }
+            let diagnostics: Diagnostic[] = [];
+
+            if (
+              project?.extensions?.languageService?.enableValidation !== false
+            ) {
+              diagnostics = (
+                await Promise.all(
+                  contents.map(async ({ query, range }) => {
+                    const results = await this._languageService.getDiagnostics(
+                      query,
+                      uri,
+                      this._isRelayCompatMode(query),
+                    );
+                    if (results && results.length > 0) {
+                      return processDiagnosticsMessage(results, query, range);
+                    }
+                    return [];
+                  }),
+                )
+              ).reduce((left, right) => left.concat(right), diagnostics);
+            }
 
-          this._logger.log(
-            JSON.stringify({
-              type: 'usage',
-              messageType: 'workspace/didChangeWatchedFiles',
-              projectName: project?.name,
-              fileName: uri,
-            }),
-          );
-          return { uri, diagnostics };
+            this._logger.log(
+              JSON.stringify({
+                type: 'usage',
+                messageType: 'workspace/didChangeWatchedFiles',
+                projectName: project?.name,
+                fileName: uri,
+              }),
+            );
+            return { uri, diagnostics };
+          } catch (err) {
+            this._handleConfigError({ err, uri });
+            return { uri, diagnostics: [] };
+          }
         }
         if (change.type === FileChangeTypeKind.Deleted) {
           await this._graphQLCache.updateFragmentDefinitionCache(