add missing effect dep for default headers (#2912)

graphql · Nov 15, 2022 · 83364b2 · 83364b2 · Huntercry · Nov 18, 2022
1 parent 118db40
commit 83364b2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/red-ligers-scream.md b/.changeset/red-ligers-scream.md
@@ -0,0 +1,6 @@
+---
+'@graphiql/react': patch
+---
+
+Add missing effect dependency to make sure updates to the `defaultHeaders` prop
+have the desired effect
diff --git a/packages/graphiql-react/src/editor/context.tsx b/packages/graphiql-react/src/editor/context.tsx
@@ -329,7 +329,13 @@ export function EditorContextProvider(props: EditorContextProviderProps) {
       onTabChange?.(updated);
       return updated;
     });
-  }, [onTabChange, setEditorValues, storeTabs, synchronizeActiveTabValues]);
+  }, [
+    props.defaultHeaders,
+    onTabChange,
+    setEditorValues,
+    storeTabs,
+    synchronizeActiveTabValues,
+  ]);
 
   const changeTab = useCallback<EditorContextType['changeTab']>(
     index => {