[ESLint] Prefer String#slice() over String#substr() and String#substr…

…ing() (#3042)

* Prefer String#slice() over String#substr() and String#substring()

* fix tests

* format

.changeset/witty-owls-burn.md

@@ -0,0 +1,7 @@
+---
+'@graphiql/react': patch
+'@graphiql/toolkit': patch
+'graphql-language-service': patch
+---
+
+Prefer String#slice() over String#substr() and String#substring()

.eslintrc.js

@@ -112,6 +112,7 @@ module.exports = {
     'require-await': 0,
     'vars-on-top': 0,
     yoda: 1,
+    'unicorn/prefer-string-slice': 'error',
     'sonarjs/no-identical-functions': 'error',
     'sonarjs/no-unused-collection': 'error',
     'sonarjs/no-extra-arguments': 'error',

packages/graphiql-react/src/editor/tabs.ts

@@ -322,7 +322,7 @@ function guid(): string {
   const s4 = () => {
     return Math.floor((1 + Math.random()) * 0x10000)
       .toString(16)
-      .substring(1);
+      .slice(1);
   };
   // return id of format 'aaaaaaaa'-'aaaa'-'aaaa'-'aaaa'-'aaaaaaaaaaaa'
   return `${s4()}${s4()}-${s4()}-${s4()}-${s4()}-${s4()}${s4()}${s4()}`;

packages/graphiql-toolkit/src/graphql-helpers/auto-complete.ts

@@ -199,7 +199,7 @@ function getIndentation(str: string, index: number) {
       indentEnd = indentStart;
     }
   }
-  return str.substring(indentStart, indentEnd);
+  return str.slice(indentStart, indentEnd);
 }
 
 function isFieldType(

packages/graphiql/resources/renderExample.js

@@ -15,7 +15,7 @@
 // Parse the search string to get url parameters.
 var parameters = {};
 window.location.search
-  .substr(1)
+  .slice(1)
   .split('&')
   .forEach(function (entry) {
     var eq = entry.indexOf('=');

packages/graphql-language-service/src/parser/CharacterStream.ts

@@ -111,7 +111,9 @@ export default class CharacterStream implements CharacterStreamInterface {
 
     if (typeof pattern === 'string') {
       const regex = new RegExp(pattern, caseFold ? 'i' : 'g');
-      match = regex.test(this._sourceText.substr(this._pos, pattern.length));
+      match = regex.test(
+        this._sourceText.slice(this._pos, this._pos + pattern.length),
+      );
       token = pattern;
     } else if (pattern instanceof RegExp) {
       match = this._sourceText.slice(this._pos).match(pattern);