enable @typescript-eslint/no-unused-expressions rule (#2933)

graphql · Dec 8, 2022 · d502a33 · d502a33
1 parent 114564b
commit d502a33
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 6 deletions.
diff --git a/.changeset/polite-crabs-double.md b/.changeset/polite-crabs-double.md
@@ -0,0 +1,6 @@
+---
+'@graphiql/react': patch
+'graphql-language-service-server': patch
+---
+
+enable @typescript-eslint/no-unused-expressions
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -142,6 +142,7 @@ module.exports = {
       'error',
       { argsIgnorePattern: '^_', ignoreRestSiblings: true },
     ],
+    '@typescript-eslint/no-unused-expressions': 'error',
 
     'no-use-before-define': 0,
 

diff --git a/examples/monaco-graphql-react-vite/src/App.tsx b/examples/monaco-graphql-react-vite/src/App.tsx
@@ -108,22 +108,24 @@ export default function App() {
     const variablesModel = getOrCreateModel('variables.json', defaultVariables);
     const resultsModel = getOrCreateModel('results.json', '{}');
 
-    queryEditor ??
+    if (!queryEditor) {
       setQueryEditor(
         createEditor(opsRef, {
           theme: 'vs-dark',
           model: queryModel,
           language: 'graphql',
         }),
       );
-    variablesEditor ??
+    }
+    if (!variablesEditor) {
       setVariablesEditor(
         createEditor(varsRef, {
           theme: 'vs-dark',
           model: variablesModel,
         }),
       );
-    resultsViewer ??
+    }
+    if (!resultsViewer) {
       setResultsViewer(
         createEditor(resultsRef, {
           theme: 'vs-dark',
@@ -132,7 +134,7 @@ export default function App() {
           smoothScrolling: true,
         }),
       );
-
+    }
     queryModel.onDidChangeContent(
       debounce(300, () => {
         localStorage.setItem('operations', queryModel.getValue());

diff --git a/packages/graphiql-react/src/utility/resize.ts b/packages/graphiql-react/src/utility/resize.ts
@@ -155,7 +155,6 @@ export function useDragResize({
       if (!Number.isFinite(flex) || flex < 1) {
         firstRef.current.style.flex = '1';
       }
-      firstRef.current.style.flex;
     }
   }, []);
 

diff --git a/packages/graphql-language-service-server/src/GraphQLCache.ts b/packages/graphql-language-service-server/src/GraphQLCache.ts
@@ -665,7 +665,9 @@ export class GraphQLCache implements GraphQLCacheInterface {
     const schemaKey = this._getSchemaCacheKeyForProject(
       projectConfig,
     ) as string;
-    schemaKey && this._schemaMap.delete(schemaKey);
+    if (schemaKey) {
+      this._schemaMap.delete(schemaKey);
+    }
   }
 
   _getSchemaCacheKeyForProject(