🛠️ ESLint: clean all ESLint warnings, add --max-warnings=0 and `--c…

…ache` flags (#2962)

* clean all ESLint warnings, add `--max-warnings=0` and `--cache` flags

* format

* rebase

.changeset/orange-carrots-decide.md

@@ -0,0 +1,10 @@
+---
+'cm6-graphql': patch
+'codemirror-graphql': patch
+'graphiql': patch
+'@graphiql/toolkit': patch
+'graphql-language-service': patch
+'graphql-language-service-server': patch
+---
+
+clean all ESLint warnings, add `--max-warnings=0` and `--cache` flags

.eslintrc.js

@@ -14,9 +14,6 @@ module.exports = {
   parserOptions: {
     ecmaVersion: 6,
     sourceType: 'module',
-    ecmaFeatures: {
-      jsx: true,
-    },
   },
   settings: {
     react: {
@@ -29,10 +26,7 @@ module.exports = {
     es6: true,
     node: true,
     browser: true,
-    jest: true,
-    'jest/globals': true,
   },
-
   extends: [
     'eslint:recommended',
     'plugin:import/recommended',
@@ -107,7 +101,7 @@ module.exports = {
     'no-script-url': 1,
     'no-self-compare': 1,
     'no-sequences': 1,
-    'no-throw-literal': 1,
+    'no-throw-literal': 'error',
     'no-unmodified-loop-condition': 0,
     'no-useless-call': 1,
     'no-useless-concat': 1,
@@ -215,7 +209,7 @@ module.exports = {
     'no-useless-computed-key': 1,
     'no-useless-constructor': 0,
     'no-useless-rename': 1,
-    'no-var': 1,
+    'no-var': 'error',
     'object-shorthand': 1,
     'prefer-arrow-callback': [0, { allowNamedFunctions: true }], // prettier --list-different
     'prefer-const': 1,
@@ -230,7 +224,7 @@ module.exports = {
     'import/no-duplicates': 'error',
     'import/no-named-as-default': 'error',
     'prefer-object-spread': 'error',
-    // react rules
+    // React rules
     'react/no-unused-state': 'error',
     'react/jsx-curly-brace-presence': 'error',
     'react/jsx-boolean-value': 'error',
@@ -258,8 +252,6 @@ module.exports = {
       'error',
       { extensions: ['.tsx', '.jsx'], allow: 'as-needed' },
     ],
-    // Jest rules
-    'jest/no-conditional-expect': 0,
 
     'unicorn/consistent-destructuring': 'error',
     'prefer-destructuring': ['error', { VariableDeclarator: { object: true } }],
@@ -300,11 +292,9 @@ module.exports = {
         '**/*.spec.{ts,js.jsx.tsx}',
       ],
       extends: ['plugin:jest/recommended'],
-      env: {
-        'jest/globals': true,
-      },
       rules: {
-        'jest/no-conditional-expect': 0,
+        'jest/no-conditional-expect': 'off',
+        'jest/expect-expect': ['error', { assertFunctionNames: ['expect*'] }],
       },
     },
     {

.gitignore

@@ -32,3 +32,4 @@ yarn-1.18.0.js
 .netlify
 
 examples/*/yarn.lock
+.eslintcache

examples/monaco-graphql-react-vite/src/App.tsx

@@ -145,14 +145,13 @@ export default function App() {
         localStorage.setItem('variables', variablesModel.getValue());
       }),
     );
-
-    // only run once on mount
+    // eslint-disable-next-line react-hooks/exhaustive-deps -- only run once on mount
   }, []);
 
   useEffect(() => {
     queryEditor?.addAction(queryAction);
     variablesEditor?.addAction(queryAction);
-  }, [variablesEditor]);
+  }, [queryEditor, variablesEditor]);
   /**
    * Handle the initial schema load
    */

package.json

@@ -51,7 +51,7 @@
     "dev-graphiql": "yarn workspace graphiql dev",
     "e2e": "yarn run e2e:build && yarn workspace graphiql e2e",
     "e2e:build": "yarn build && yarn workspace graphiql run build-bundles-min",
-    "eslint": "eslint --ext=ts,js,jsx,tsx .",
+    "eslint": "eslint --max-warnings=0 --cache --ext=ts,js,jsx,tsx .",
     "format": "yarn eslint --fix && yarn pretty",
     "jest": "jest",
     "license-check": "jsgl --local ./",

packages/cm6-graphql/__tests__/test.spec.ts

@@ -1,3 +1,4 @@
+/* eslint-disable jest/expect-expect */
 import { graphqlLanguage } from '../dist/index.js';
 import { fileTests } from '@lezer/generator/dist/test';
 

packages/codemirror-graphql/src/index.d.ts

@@ -1,7 +1,7 @@
 import 'codemirror/addon/hint/show-hint';
 
 declare module 'codemirror' {
-  var Init: any;
+  let Init: any;
 
   interface Editor {
     doc: CodeMirror.Doc;

packages/codemirror-graphql/src/utils/__tests__/jsonParse-test.ts

@@ -9,7 +9,7 @@
 import jsonParse, { ParseTokenOutput } from '../jsonParse';
 
 describe('jsonParse', () => {
-  function checkEscapedString(
+  function expectEscapedString(
     str: string,
     key: ParseTokenOutput,
     value: ParseTokenOutput,
@@ -21,17 +21,17 @@ describe('jsonParse', () => {
   }
 
   it('correctly parses escaped strings', () => {
-    checkEscapedString(
+    expectEscapedString(
       '{ "test": "\\"" }',
       { kind: 'String', start: 2, end: 8, value: 'test' },
       { kind: 'String', start: 10, end: 14, value: '"' },
     );
-    checkEscapedString(
+    expectEscapedString(
       '{ "test": "\\\\" }',
       { kind: 'String', start: 2, end: 8, value: 'test' },
       { kind: 'String', start: 10, end: 14, value: '\\' },
     );
-    checkEscapedString(
+    expectEscapedString(
       '{ "slash": "\\/" }',
       { kind: 'String', start: 2, end: 9, value: 'slash' },
       { kind: 'String', start: 11, end: 15, value: '/' },

packages/codemirror-graphql/src/variables/__tests__/hint-test.ts

@@ -48,7 +48,7 @@ function getHintSuggestions(
   });
 }
 
-function checkSuggestions(source: string[], suggestions?: IHint[]) {
+function expectSuggestions(source: string[], suggestions?: IHint[]) {
   const titles = suggestions?.map(suggestion => suggestion.text);
   expect(titles).toEqual(source);
 }
@@ -62,7 +62,7 @@ describe('graphql-variables-hint', () => {
   it('provides correct initial token', async () => {
     const suggestions = await getHintSuggestions('', '', { line: 0, ch: 0 });
     const initialKeywords = ['{'];
-    checkSuggestions(initialKeywords, suggestions?.list);
+    expectSuggestions(initialKeywords, suggestions?.list);
   });
 
   it('provides correct field name suggestions', async () => {
@@ -71,7 +71,7 @@ describe('graphql-variables-hint', () => {
       '{ ',
       { line: 0, ch: 2 },
     );
-    checkSuggestions(['"foo": ', '"bar": '], suggestions?.list);
+    expectSuggestions(['"foo": ', '"bar": '], suggestions?.list);
   });
 
   it('provides correct variable suggestion indentation', async () => {
@@ -90,7 +90,7 @@ describe('graphql-variables-hint', () => {
       '{\n  ba',
       { line: 1, ch: 4 },
     );
-    checkSuggestions(['"bar": '], suggestions?.list);
+    expectSuggestions(['"bar": '], suggestions?.list);
     expect(suggestions?.from).toEqual({ line: 1, ch: 2, sticky: null });
     expect(suggestions?.to).toEqual({ line: 1, ch: 4, sticky: null });
   });
@@ -101,7 +101,7 @@ describe('graphql-variables-hint', () => {
       '{\n  "',
       { line: 1, ch: 4 },
     );
-    checkSuggestions(['"foo": ', '"bar": '], suggestions?.list);
+    expectSuggestions(['"foo": ', '"bar": '], suggestions?.list);
     expect(suggestions?.from).toEqual({ line: 1, ch: 2, sticky: null });
     expect(suggestions?.to).toEqual({ line: 1, ch: 3, sticky: null });
   });
@@ -113,7 +113,7 @@ describe('graphql-variables-hint', () => {
       { line: 1, ch: 12 },
     );
     const TestEnum = TestSchema.getType('TestEnum');
-    checkSuggestions(
+    expectSuggestions(
       (TestEnum as GraphQLEnumType)
         ?.getValues()
         .map(value => `"${value.name}"`),
@@ -127,7 +127,7 @@ describe('graphql-variables-hint', () => {
       '{\n  "myInput": ',
       { line: 1, ch: 13 },
     );
-    checkSuggestions(['{'], suggestions?.list);
+    expectSuggestions(['{'], suggestions?.list);
   });
 
   it('provides Input Object fields', async () => {
@@ -137,7 +137,7 @@ describe('graphql-variables-hint', () => {
       { line: 2, ch: 4 },
     );
     const TestInput = TestSchema.getType('TestInput');
-    checkSuggestions(
+    expectSuggestions(
       Object.keys((TestInput as GraphQLInputObjectType).getFields()).map(
         name => `"${name}": `,
       ),
@@ -153,7 +153,7 @@ describe('graphql-variables-hint', () => {
       '{\n  "myInput": {\n    bool',
       { line: 2, ch: 8 },
     );
-    checkSuggestions(['"boolean": ', '"listBoolean": '], suggestions?.list);
+    expectSuggestions(['"boolean": ', '"listBoolean": '], suggestions?.list);
     expect(suggestions?.from).toEqual({ line: 2, ch: 4, sticky: null });
     expect(suggestions?.to).toEqual({ line: 2, ch: 8, sticky: null });
   });
@@ -164,6 +164,6 @@ describe('graphql-variables-hint', () => {
       '{\n  "myInput": {\n    "boolean": ',
       { line: 2, ch: 15 },
     );
-    checkSuggestions(['true', 'false'], suggestions?.list);
+    expectSuggestions(['true', 'false'], suggestions?.list);
   });
 });

packages/graphiql-toolkit/src/create-fetcher/__tests__/lib.spec.ts

@@ -105,6 +105,7 @@ describe('missing graphql-ws dependency', () => {
   it('should throw a nice error', () => {
     jest.resetModules();
     jest.doMock('graphql-ws', () => {
+      // eslint-disable-next-line no-throw-literal
       throw { code: 'MODULE_NOT_FOUND' };
     });