Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support graphql@15.0.0 release #1191

Closed
IvanGoncharov opened this issue Jan 6, 2020 · 10 comments
Closed

Support graphql@15.0.0 release #1191

IvanGoncharov opened this issue Jan 6, 2020 · 10 comments
Labels
dependencies Pull requests that update a dependency file
Projects
3. Complete LSP Features 1. GraphiQL React 16 Migration + Context
Milestone
monaco-graphql@0....

Comments

@IvanGoncharov
Copy link
Member

@acao @benjie Took a long long time than I initially anticipated but I finally released graphql@15.0.0-rc1.
It includes a number of small breaking changes:
https://github.com/graphql/graphql-js/releases/tag/v15.0.0-alpha.1
https://github.com/graphql/graphql-js/releases/tag/v15.0.0-alpha.2
https://github.com/graphql/graphql-js/releases/tag/v15.0.0-rc.1

Can you please test it with packages in this repo so I can release 15.0.0 without worrying about breaking GraphiQL?

Note: It doesn't yet include two-stage introspection that I currently working on and will add in the next release since it's not a breaking change.
@acao
Copy link
Member

acao commented Jan 6, 2020

awesome work @IvanGoncharov ! i tested it with first alpha before, looking forward to giving it a spin!

@acao
Copy link
Member

acao commented Jan 8, 2020

@IvanGoncharov good news, only a few failing tests around error message formatting, and the minified build is looking solid with some manual and automated tests. I'll push a PR tonight, and hopefully I can check in on some of the breaking changes in more depth, as well as test out the LSP server

@acao acao mentioned this issue Jan 8, 2020
Merged
7 tasks
@acao
Copy link
Member

acao commented Jan 8, 2020

yeah just that one failing test related to graphql-config for the dev server. everything else is looking great overall. I'll keep it open and bump to the next RC if/when that comes.

@ardatan ardatan mentioned this issue Jan 14, 2020
Closed
2 tasks
@IvanGoncharov
Copy link
Member Author

@acao @benjie Just release RC2 can you please test it?
https://github.com/graphql/graphql-js/releases/tag/v15.0.0-rc.2

@acao
Copy link
Member

acao commented Feb 12, 2020

yes, can do!

@acao acao mentioned this issue Feb 16, 2020
Merged
2 tasks
acao added a commit that referenced this issue Apr 5, 2020
@acao
feat: upgrade to graphql@15.0.0 for #1191 (#1204)
f13c8e9 
* graphql 15 stable
* all but one type error in graphql-config@3.0.0-rc.2
* skipLibCheck and ignore node_nodules
* more efficient node_modules ignore for tsconfig
@acao
Copy link
Member

acao commented Apr 6, 2020

@IvanGoncharov as noted on the PR we merged, we need to remove peer resolutions up to graphql 14 across the board, correct?

@acao acao added this to Backlog in 3. Complete LSP Features via automation Apr 6, 2020
@acao acao added this to To do in 1. GraphiQL React 16 Migration + Context via automation Apr 6, 2020
@acao acao added the dependencies Pull requests that update a dependency file label Apr 6, 2020
@acao acao changed the title Test with graphql@15.0.0-rc.1 release Suport graphql@15.0.0 release Apr 6, 2020
@acao acao changed the title Suport graphql@15.0.0 release Support graphql@15.0.0 release Apr 6, 2020
@IvanGoncharov
Copy link
Member Author

@acao Yes, it would be great!

@acao acao moved this from Done to In progress in 1. GraphiQL React 16 Migration + Context Apr 14, 2020
@acao
Copy link
Member

acao commented Apr 14, 2020 •
edited
Loading

ok great @IvanGoncharov, i did a patch alpha release of the #1204 upgrade, and will follow up with peer resolutions!

@acao
Copy link
Member

acao commented Apr 14, 2020

then we can follow up with seperate issues for adopting each new feature, i can create a whole project on here for it

@acao
Copy link
Member

acao commented May 23, 2020 •
edited
Loading

@IvanGoncharov going to close this, we pre-released with baseline 15 support a while ago, and i'm going to open new issues to adopt new features, as we are likely about to rebuild the doc explorer from scratch

@acao acao closed this as completed May 23, 2020
3. Complete LSP Features automation moved this from Backlog to Done May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
3. Complete LSP Features
  
Done
1. GraphiQL React 16 Migration + Context
  
In progress
Milestone
monaco-graphql@0.10.0
Development

No branches or pull requests
2 participants
@acao @IvanGoncharov