Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphiql height is not 100% #87

Closed
blaiprat opened this issue Feb 3, 2016 · 9 comments
Closed

Graphiql height is not 100% #87

blaiprat opened this issue Feb 3, 2016 · 9 comments

Comments

@blaiprat
Copy link

blaiprat commented Feb 3, 2016

When I open Graphiql it looks like this
screen shot 2016-02-03 at 11 35 53

It looks like that html and body tags need to have their height set to 100% so the layer #graphiql-container can expand too.

I've tried also opening in safari and in chrome on incognito window (without any extension running) and the same happens.

@KATT
Copy link

KATT commented Feb 3, 2016

+1

@leebyron
Copy link
Contributor

leebyron commented Feb 3, 2016

Are you running graphiql via express-graphql?

I realized that I had just released a breaking change in a point release, so I republished to account for the breaking change. I'll make the change to express-graphql now as well.

@leebyron
Copy link
Contributor

leebyron commented Feb 3, 2016

Ok, I could easily reproduce this issue when trying to update http://graphql-swapi.parseapp.com/. I've got new versions of both graphiql and express-graphql on npm which should fix this, and have unpublished the offending ones so people don't accidentally run into this when they npm install!

Thanks again for the fast report

@leebyron leebyron closed this as completed Feb 3, 2016
@blaiprat
Copy link
Author

blaiprat commented Feb 3, 2016

Reinstalled node_modules and it shows fine now. Thanks for the quick fix and the awesome work!

@leebyron
Copy link
Contributor

leebyron commented Feb 3, 2016

Most excellent, thanks for confirming the fix!

@mkuts12
Copy link

mkuts12 commented May 17, 2016

Hey @leebyron, I have the same issue but I don't use express-graphql.
I work in a company with closed network and express-graphql uses cdns.

I use webpack with css and style loaders for the css.
I've made a project with the problem. It's very simple and I will be happy if you help me. I'm simply lost

https://github.com/mkuts12/graphiql-testing

@mkuts12
Copy link

mkuts12 commented May 17, 2016

Hey again,
after investing almost two days into figuring out what the hell is going on, it appears that the problem is the id of the div i try to render into.
In your example it is set to 'graphiql' and in my project it is 'app'.
when chaning my app to 'graphiql' it worked. and when changing in your example 'graphql' to 'unique' it didn't work anymore.

I am shocked

@mkuts12
Copy link

mkuts12 commented May 17, 2016

I am infinitely sorry. Of course it won't work since the way css works.
maybe you can write about it in the readme or bind the css to the component, please?

@leebyron
Copy link
Contributor

I'm glad you figured out what was going on! I'll find a way to make the css bindings more appropriate so that this kind of issue is harder to get yourself into in the future.

acao pushed a commit to acao/graphiql that referenced this issue Jun 5, 2019
….2.0

Update babel-eslint to version 7.2.0 🚀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants