Graphiql tries to read string as integer and fails since it starts with 07

[buma]

I am using java-graphql and graphiql for testing. I added custom graphql type for time which is represented as string in GraphQL but problem is that GraphiQL fails when parsing introspection query since it seems to try to read defaultValue it as integer and fails. Since I get an error:

Syntax Error GraphQL (1:2) Invalid number, unexpected digit after 0: "7".

1: 07:30

It works correctly in "toTime" which has defaultValue 10:00. And it also works correctly if defaultValue is "7:30".
This is part of introspection response:

{
                  "name": "fromTime",
                  "description": "The beginning of the departure window, in HH:MM",
                  "type": {
                    "kind": "SCALAR",
                    "name": "String",
                    "ofType": null
                  },
                  "defaultValue": "07:30"
                },

And link to full response.

[asiandrummer]

@buma so I've tried to reproduce with example app, and got this:

defaultValue: ""07:30"" // notice the difference here
description: "test string time"
name: "time"
type: {
  kind: "SCALAR"
  name: "String"
  ofType: null
}

I was thinking this might be a difference between how GraphQLInputObjectType is build in graphql-java and graphql-js - @leebyron would you have an idea what's happening here?

[buma]

Interesting. @andimarek any idea if this is graphql-java bug or bug in my code?

GraphQLFieldDefinition planField = GraphQLFieldDefinition.newFieldDefinition()
            .name("plan")
            .description("Gets plan of a route at a specific time")
            .type(profileResponseType)
            .argument(GraphQLArgument.newArgument().name("from")
                .type(new GraphQLNonNull(inputCoordinateType)).build())
            .argument(GraphQLArgument.newArgument()
                .name("to")
                .type(new GraphQLNonNull(inputCoordinateType))
                .build())
            .argument(GraphQLArgument.newArgument()
                .name("fromTime")
                .type(Scalars.GraphQLString)
                .description("The beginning of the departure window, in HH:MM")
                .defaultValue("07:30")
                .build())
            .argument(GraphQLArgument.newArgument()
                .name("toTime")
                .type(Scalars.GraphQLString)
                .description("The end of the departure window, in HH:MM")
                .defaultValue("10:30")
                .build())
          .build();

[leebyron]

Thanks for the report! From @asiandrummer's analysis this appears to be a clear bug in graphql-java or at least a shortcoming in the API

http://facebook.github.io/graphql/#sec-The-__InputValue-Type

This part of the spec describes the default value field as being a string encoded in the graphql language. So we can provide numbers, booleans, and strings with "3", "true", and ""str"", respectively.