Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search icon misalignment #1776

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

iifawzi
Copy link
Contributor

@iifawzi iifawzi commented Jan 26, 2021

Closes #1773

Since using top can't produce the same result in different screens due to many reasons, I changed the search-box display to flex, and centered the icons inside it.

let me know if you do prefer using different approach.

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #1776 (cfb0fc6) into main (881d8b5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1776   +/-   ##
=======================================
  Coverage   65.95%   65.95%           
=======================================
  Files          83       83           
  Lines        4991     4991           
  Branches     1581     1581           
=======================================
  Hits         3292     3292           
  Misses       1672     1672           
  Partials       27       27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 881d8b5...cfb0fc6. Read the comment docs.

@acao acao force-pushed the main branch 6 times, most recently from 4fa9ca3 to 1c11938 Compare February 1, 2021 18:22
@acao
Copy link
Member

acao commented Feb 2, 2021

thanks a bunch for this @iifawzi ! releasing this today

@acao acao merged commit 3dbc90b into graphql:main Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search icon misalignment issue
3 participants