Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updating #999 font colors to #666 #1883

Merged
merged 3 commits into from
Oct 29, 2021
Merged

fix: updating #999 font colors to #666 #1883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69e952f
fix: updating #999 font colors to #666
Sweetabix Jun 4, 2021
cd54b03
add changeset
acao Sep 3, 2021
a81ed75
fix: formatting fix for prettier
acao Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/light-olives-rush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'graphiql-2-rfc-context': patch
'graphiql': patch
---

Updating font colors for line numbers, comments & brackets from #999 to #666 for accessibility purposes. #666 passes AA accessibility standards for small text, with a contrast ratio of over 5:1.
2 changes: 1 addition & 1 deletion packages/graphiql-2-rfc-context/src/components/common/themes/default/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { Colors, Space, GraphiQLTheme } from '../types';

const palette = {
neutral: {
20: '#999999',
20: '#666666',
70: '#333333',
90: `rgba(0, 0, 0, 0.1)`,
100: '#fff',
Expand Down
2 changes: 1 addition & 1 deletion packages/graphiql/src/css/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ div.CodeMirror-lint-tooltip > * + * {

/* Comment */
.cm-comment {
color: #999;
color: #666;
}

/* Punctuation */
Expand Down
8 changes: 4 additions & 4 deletions packages/graphiql/src/css/codemirror.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@
}
.CodeMirror-linenumbers {}
.CodeMirror-linenumber {
color: #999;
color: #666;
min-width: 20px;
padding: 0 3px 0 5px;
text-align: right;
white-space: nowrap;
}

.CodeMirror-guttermarker { color: black; }
.CodeMirror-guttermarker-subtle { color: #999; }
.CodeMirror-guttermarker-subtle { color: #666; }

/* CURSOR */

Expand Down Expand Up @@ -96,12 +96,12 @@ div.CodeMirror-overwrite div.CodeMirror-cursor {}
.cm-s-default .cm-meta {color: #555;}
.cm-s-default .cm-qualifier {color: #555;}
.cm-s-default .cm-builtin {color: #30a;}
.cm-s-default .cm-bracket {color: #997;}
.cm-s-default .cm-bracket {color: #666;}
.cm-s-default .cm-tag {color: #170;}
.cm-s-default .cm-attribute {color: #00c;}
.cm-s-default .cm-header {color: blue;}
.cm-s-default .cm-quote {color: #090;}
.cm-s-default .cm-hr {color: #999;}
.cm-s-default .cm-hr {color: #666;}
.cm-s-default .cm-link {color: #00c;}

.cm-negative {color: #d44;}
Expand Down
2 changes: 1 addition & 1 deletion packages/graphiql/src/css/doc-explorer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
}

.graphiql-container .field-short-description {
color: #999;
color: #666;
margin-left: 5px;
overflow: hidden;
text-overflow: ellipsis;
Expand Down