Fix unknown fragment errors on save

[p-szm]

Fixes #1963

[changeset-bot]

🦋 Changeset detected

Latest commit: b75ac02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
graphql-language-service-server	Patch
graphql-language-service	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Patrick Szmucer (c977693, 3c9d4d7)

[acao]

Hmm thanks! I will have to check into the history of these function signatures and see why the legacy relay compat mode was originally inverted there, but if it seems to fix the issue that’s good. You’ve tested this fix locally?

[codecov]

Codecov Report

Merging #1964 (b75ac02) into main (2d91916) will increase coverage by 0.74%.
The diff coverage is 68.31%.

@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
+ Coverage   65.70%   66.45%   +0.74%     
==========================================
  Files          85       86       +1     
  Lines        5106     5142      +36     
  Branches     1631     1639       +8     
==========================================
+ Hits         3355     3417      +62     
+ Misses       1747     1721      -26     
  Partials        4        4              

Impacted Files	Coverage Δ
...ackages/graphiql-toolkit/src/create-fetcher/lib.ts	50.90% <20.00%> (-8.67%)	⬇️
packages/graphiql/src/utility/HistoryStore.ts	62.26% <62.26%> (ø)
packages/graphiql/src/components/QueryHistory.tsx	73.91% <76.47%> (+6.69%)	⬆️
...iql/src/components/DocExplorer/MarkdownContent.tsx	100.00% <100.00%> (ø)
packages/graphiql/src/components/GraphiQL.tsx	58.34% <100.00%> (+0.83%)	⬆️
...ql-language-service-server/src/MessageProcessor.ts	66.58% <100.00%> (+6.30%)	⬆️
...hql-language-service-server/src/findGraphQLTags.ts	67.64% <100.00%> (+7.00%)	⬆️
...raphql-language-service-server/src/GraphQLCache.ts	52.25% <0.00%> (+0.60%)	⬆️
packages/graphiql/src/utility/QueryStore.ts	42.85% <0.00%> (+2.04%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1d3a6...b75ac02. Read the comment docs.

[p-szm]

I've tested locally and it fixes the issue, but I haven't tested the relay compat mode (I'm not sure how to).

I git blamed this line and this is when it was introduced 5d073d2 but I can't find any PR associated with it.

[acao]

@patrickszmucer awesome to hear! the relay compat mode is for ancient relay 1 legacy support, I would consider it mostly deprecated and would be removed in the future.

[acao]

@patrickszmucer are you able to sign the CLA? you only need to do it once for any Linux Foundation or GraphQL Foundation project :)

[p-szm]

@acao apologies for the delay here - I'll have the CLA signed soon

[p-szm]

@acao done! Again, sorry for the delay from my side.

[acao]

np! @patrickszmucer really appreciate this!

[acao]

I can add a changeset, oops forgot to mention that as well