Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix graphql peer deps #2044

Merged
merged 1 commit into from Nov 23, 2021
Merged

fix graphql peer deps #2044

merged 1 commit into from Nov 23, 2021

Conversation

acao
Copy link
Member

@acao acao commented Nov 23, 2021

this should work better for consumers

@changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2021

⚠️ No Changeset found

Latest commit: 32c66cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview November 23, 2021 21:09 Inactive
@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview November 23, 2021 21:09 Inactive
@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview November 23, 2021 21:11 Inactive
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #2044 (32c66cb) into main (2d91916) will decrease coverage by 1.51%.
The diff coverage is 62.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2044      +/-   ##
==========================================
- Coverage   65.70%   64.19%   -1.52%     
==========================================
  Files          85       94       +9     
  Lines        5106     5424     +318     
  Branches     1631     1709      +78     
==========================================
+ Hits         3355     3482     +127     
- Misses       1747     1937     +190     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx 63.96% <ø> (ø)
...graphiql/src/components/__tests__/ExampleSchema.ts 100.00% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c83d1d4...32c66cb. Read the comment docs.

@acao acao merged commit d0f1273 into main Nov 23, 2021
@acao acao deleted the fix-peer-deps-graphql branch November 23, 2021 21:39
@github-actions github-actions bot mentioned this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant