Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing changeset, fix e2e, node 16 #2045

Merged
merged 2 commits into from
Nov 24, 2021
Merged

missing changeset, fix e2e, node 16 #2045

merged 2 commits into from
Nov 24, 2021

Conversation

acao
Copy link
Member

@acao acao commented Nov 24, 2021

the node 16 upgrade seems to make yarn install about ~40s faster in github actions!

@changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2021

🦋 Changeset detected

Latest commit: 5e0124b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
codemirror-graphql Patch
graphiql Patch
@graphiql/toolkit Patch
graphql-language-service Patch
graphql-language-service-interface Patch
graphql-language-service-parser Patch
graphql-language-service-server Patch
graphql-language-service-types Patch
graphql-language-service-utils Patch
monaco-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2021

@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview November 24, 2021 09:46 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2021

@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview November 24, 2021 09:46 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2021

The latest changes of this PR are available as canary in npm (based on the declared changesets):

codemirror-graphql@1.2.1-canary-98364dae.0
graphiql@1.5.3-canary-98364dae.0
@graphiql/toolkit@0.4.2-canary-98364dae.0
graphql-language-service@3.2.2-canary-98364dae.0
graphql-language-service-cli@3.2.3-canary-98364dae.0
graphql-language-service-interface@2.9.2-canary-98364dae.0
graphql-language-service-parser@1.10.1-canary-98364dae.0
graphql-language-service-server@2.7.3-canary-98364dae.0
graphql-language-service-types@1.8.4-canary-98364dae.0
graphql-language-service-utils@2.6.1-canary-98364dae.0
monaco-graphql@0.6.2-canary-98364dae.0

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #2045 (5e0124b) into main (2d91916) will decrease coverage by 1.51%.
The diff coverage is 62.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2045      +/-   ##
==========================================
- Coverage   65.70%   64.19%   -1.52%     
==========================================
  Files          85       94       +9     
  Lines        5106     5424     +318     
  Branches     1631     1709      +78     
==========================================
+ Hits         3355     3482     +127     
- Misses       1747     1937     +190     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx 63.96% <ø> (ø)
...graphiql/src/components/__tests__/ExampleSchema.ts 100.00% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f1273...5e0124b. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2021

@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview November 24, 2021 09:46 Inactive
@acao
Copy link
Member Author

acao commented Nov 24, 2021

for some reason, these canaries still have different peer dependencies than we have in main... :( @dotansimha do you know why this would be? for example, installing graphql-language-service-server still shows the wrong peer dependencies for graphql-language-service, i'm not sure why

@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview November 24, 2021 09:58 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview November 24, 2021 09:59 Inactive
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview November 24, 2021 10:00 Inactive
@acao acao changed the title missing changeset, fix e2e missing changeset, fix e2e, node 16 Nov 24, 2021
@acao acao merged commit 858907d into main Nov 24, 2021
@acao acao deleted the changeset-missing branch November 24, 2021 10:03
@github-actions github-actions bot mentioned this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant