Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codemirror-graphql's mode-factory.ts to use graphql-language-service #2046

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

willstott101
Copy link
Contributor

Follow on from #2037

@changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2021

🦋 Changeset detected

Latest commit: aae6b8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
codemirror-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acao
Copy link
Member

acao commented Nov 24, 2021

Oops good catch! I merged these in the wrong order it seems

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #2046 (aae6b8d) into main (2d91916) will decrease coverage by 1.51%.
The diff coverage is 62.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2046      +/-   ##
==========================================
- Coverage   65.70%   64.19%   -1.52%     
==========================================
  Files          85       94       +9     
  Lines        5106     5424     +318     
  Branches     1631     1709      +78     
==========================================
+ Hits         3355     3482     +127     
- Misses       1747     1937     +190     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx 63.96% <ø> (ø)
...graphiql/src/components/__tests__/ExampleSchema.ts 100.00% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be093fd...aae6b8d. Read the comment docs.

@acao acao merged commit 8b48655 into graphql:main Nov 24, 2021
@github-actions github-actions bot mentioned this pull request Nov 24, 2021
@willstott101 willstott101 deleted the patch-2 branch November 24, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants