Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover syntax highlighting for types #2065

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Add hover syntax highlighting for types #2065

merged 1 commit into from
Dec 1, 2021

Conversation

acao
Copy link
Member

@acao acao commented Nov 28, 2021

This applies to all implementations essentially. because it's opt-in for direct usage with getAutocompleteSuggestions, codemirror-graphql will be unaffected.

the lsp server, monaco-graphql and others will be able to use the markdown output
this is just the start!

Screenshot 2021-11-28 at 01 23 07

where to test:

  1. monaco-graphql
  2. graphql-language-service-server

@acao acao added language-services lsp-server graphql-language-service-server monaco-graphql labels Nov 28, 2021
@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2021

🦋 Changeset detected

Latest commit: 38e6762

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
graphql-language-service Patch
graphql-language-service-interface Patch
graphql-language-service-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2021

The latest changes of this PR are available as canary in npm (based on the declared changesets):

codemirror-graphql@1.2.5-canary-3dcdd158.0
graphiql@1.5.8-canary-3dcdd158.0
graphql-language-service@3.2.5-canary-3dcdd158.0
graphql-language-service-cli@3.2.7-canary-3dcdd158.0
graphql-language-service-interface@2.9.5-canary-3dcdd158.0
graphql-language-service-server@2.7.7-canary-3dcdd158.0
monaco-graphql@0.6.5-canary-3dcdd158.0

@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #2065 (38e6762) into main (2d91916) will decrease coverage by 2.33%.
The diff coverage is 64.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2065      +/-   ##
==========================================
- Coverage   65.70%   63.37%   -2.34%     
==========================================
  Files          85       94       +9     
  Lines        5106     5458     +352     
  Branches     1631     1717      +86     
==========================================
+ Hits         3355     3459     +104     
- Misses       1747     1994     +247     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx 63.96% <ø> (ø)
...graphiql/src/components/__tests__/ExampleSchema.ts 100.00% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503c376...38e6762. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2021

@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview November 28, 2021 00:24 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2021

@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview November 28, 2021 00:24 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2021

@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview November 28, 2021 00:25 Inactive
This applies to all implementations essentially. because it's opt-in for direct usage with `getAutocompleteSuggestions`, `codemirror-graphql` will be unaffected.

the lsp server, monaco-graphql and others will be able to use the markdown output
this is just the start!
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview November 28, 2021 00:32 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview November 28, 2021 00:32 Inactive
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview November 28, 2021 00:33 Inactive
@acao acao merged commit df57cd2 into main Dec 1, 2021
@acao acao deleted the improve-hover branch December 1, 2021 09:31
@github-actions github-actions bot mentioned this pull request Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement lsp-server graphql-language-service-server monaco-graphql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant