Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: append insertText instead of variable labels #2076

Merged
merged 1 commit into from Dec 4, 2021
Merged

Conversation

acao
Copy link
Member

@acao acao commented Dec 3, 2021

fix a potential issue where field(arg: $| in codemirror-graphql might have autocompletion insert of $$variable because of recent changes to completion for monaco-graphql/vscode-graphql

fix a potential issue where field(arg: $| in codemirror-graphql might have autocompletion insert of $\$variable because of recent changes to completion for monaco-graphql/vscode-graphql
@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2021

🦋 Changeset detected

Latest commit: c1cf82c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphql-language-service-interface Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 3, 2021 22:27 Inactive
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #2076 (c1cf82c) into main (2d91916) will decrease coverage by 2.16%.
The diff coverage is 67.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2076      +/-   ##
==========================================
- Coverage   65.70%   63.54%   -2.17%     
==========================================
  Files          85       94       +9     
  Lines        5106     5483     +377     
  Branches     1631     1690      +59     
==========================================
+ Hits         3355     3484     +129     
- Misses       1747     1994     +247     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx 63.96% <ø> (ø)
...graphiql/src/components/__tests__/ExampleSchema.ts 100.00% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe5bb0d...c1cf82c. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

The latest changes of this PR are available as canary in npm (based on the declared changesets):

codemirror-graphql@1.2.6-canary-eb5c4300.0
graphiql@1.5.9-canary-eb5c4300.0
graphql-language-service@3.2.6-canary-eb5c4300.0
graphql-language-service-cli@3.2.8-canary-eb5c4300.0
graphql-language-service-interface@2.9.6-canary-eb5c4300.0
graphql-language-service-server@2.7.8-canary-eb5c4300.0
monaco-graphql@0.6.6-canary-eb5c4300.0

@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 3, 2021 22:27 Inactive
@acao acao requested a review from imolorhe December 3, 2021 22:28
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 3, 2021 22:28 Inactive
@acao acao merged commit 581df6d into main Dec 4, 2021
@acao acao deleted the fix/use-insert-text branch December 4, 2021 14:48
This was referenced Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants