Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix monaco-graphql bug with _cacheSchemas() #2105

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Conversation

acao
Copy link
Member

@acao acao commented Dec 8, 2021

Introduced this slight bug with major impact to monaco-graphql last night whilst moving things around.

Actual Behavior:

No language features appear. Schema request completes but the editor doesn't appear to load features.

Expected behavior:

Language features should appear

Followup:
Need a basic jest and/or cypress suite for monaco-graphql asap! Jest looks difficult with monaco-editor from what I've read

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2021

🦋 Changeset detected

Latest commit: 3ef32d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
monaco-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2021

The latest changes of this PR are available as canary in npm (based on the declared changesets):

monaco-graphql@1.0.6-canary-9129bfb9.0

@acao acao changed the title fix cache schema bug i introduced last night, oops! fix monaco-graphql bug with _cacheSchemas() Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #2105 (3ef32d1) into main (2d91916) will decrease coverage by 1.03%.
The diff coverage is 76.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2105      +/-   ##
==========================================
- Coverage   65.70%   64.66%   -1.04%     
==========================================
  Files          85       77       -8     
  Lines        5106     5168      +62     
  Branches     1631     1641      +10     
==========================================
- Hits         3355     3342      -13     
- Misses       1747     1822      +75     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx 63.96% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
...kages/graphiql/src/utility/introspectionQueries.ts 100.00% <ø> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d634f8...3ef32d1. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2021

@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 8, 2021 12:29 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 8, 2021 12:29 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 8, 2021 12:29 Inactive
@acao acao force-pushed the fix/monaco-graphql-bug branch 2 times, most recently from c51ba4b to 0305891 Compare December 8, 2021 12:31
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 8, 2021 12:34 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 8, 2021 12:34 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 8, 2021 12:34 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 8, 2021 12:38 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 8, 2021 12:38 Inactive
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 8, 2021 12:38 Inactive
@acao acao merged commit f7dc1f1 into main Dec 8, 2021
@acao acao deleted the fix/monaco-graphql-bug branch December 8, 2021 12:40
@github-actions github-actions bot mentioned this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant