Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Windows fileUri to resolve type definition #2214

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

Cellule
Copy link
Contributor

@Cellule Cellule commented Feb 27, 2022

Fixes #2212
Use URI.file instead of URI.parse to convert fs path to fileUri

I found in some places there's the variable filePath: Uri which is a bit confusing because type says it's an Uri, but variable name says it's a path.

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2022

🦋 Changeset detected

Latest commit: ef12543

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphql-language-service-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 27, 2022

CLA Signed

The committers are authorized under a signed CLA.

@acao
Copy link
Member

acao commented Feb 27, 2022

Brilliant, thank you! This will be a welcome bugfix for windows users

can you add a changeset for the server as per the comment? The CLI will automatically patch increment

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #2214 (ad705c3) into main (2d91916) will decrease coverage by 0.84%.
The diff coverage is 77.85%.

❗ Current head ad705c3 differs from pull request most recent head ef12543. Consider uploading reports for the commit ef12543 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2214      +/-   ##
==========================================
- Coverage   65.70%   64.85%   -0.85%     
==========================================
  Files          85       77       -8     
  Lines        5106     5196      +90     
  Branches     1631     1658      +27     
==========================================
+ Hits         3355     3370      +15     
- Misses       1747     1822      +75     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx 63.96% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
...kages/graphiql/src/utility/introspectionQueries.ts 100.00% <ø> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e0005...ef12543. Read the comment docs.

@Cellule
Copy link
Contributor Author

Cellule commented Feb 27, 2022

@acao I hope this does the trick :)
Thank for the quick replies, really motivated me to push it to the finish line

@acao
Copy link
Member

acao commented Mar 8, 2022

Looking great! i just have one tweak to add, can you give me permissions to write to your branch?

@acao
Copy link
Member

acao commented Mar 8, 2022

I will add in another commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to resolve resource on Windows
2 participants