Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gently trap graphql parse errors in the LS and LSP #2378

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

acao
Copy link
Member

@acao acao commented Apr 26, 2022

I introduced these accidentally and they have caused a lot of issues!

should fix #2376 and many others

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2022

🦋 Changeset detected

Latest commit: 94076a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
graphql-language-service Patch
graphql-language-service-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

I introduced these accidentally and they have caused a lot of issues!
@github-actions
Copy link
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #2378 (94076a3) into main (2d91916) will decrease coverage by 0.98%.
The diff coverage is 73.73%.

@@            Coverage Diff             @@
##             main    #2378      +/-   ##
==========================================
- Coverage   65.70%   64.72%   -0.99%     
==========================================
  Files          85       81       -4     
  Lines        5106     5324     +218     
  Branches     1631     1703      +72     
==========================================
+ Hits         3355     3446      +91     
- Misses       1747     1874     +127     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee77792...94076a3. Read the comment docs.

@acao
Copy link
Member Author

acao commented Apr 26, 2022

for the longest time I had been blaming graphql-config - but this was my mistake when I introduced the externalFragments feature!

@acao acao merged commit d22f611 into main Apr 26, 2022
@acao acao deleted the trap-parse-errors branch April 26, 2022 11:37
@github-actions github-actions bot mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic when schemas exists empty type
1 participant