don't crash lsp server on graphql config errors #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e89be6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
acao
changed the title
|
The latest changes of this PR are available as canary in npm (based on the declared |
Codecov Report
@@ Coverage Diff @@
## main #2470 +/- ##
==========================================
+ Coverage 65.70% 68.76% +3.05%
==========================================
Files 85 71 -14
Lines 5106 4223 -883
Branches 1631 1410 -221
==========================================
- Hits 3355 2904 -451
+ Misses 1747 1315 -432
Partials 4 4
Continue to review full report at Codecov.
|
Aims to resolve #2421 - graphql config errors only log to output channel, no longer crash the LSP - more performant LSP request no-ops for failing/missing config this used to fail silently in the output channel, but vscode introduced a new retry and notification for this would like to provide more helpful graphql config DX in the future but this should be better for now
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to resolve #2421
this used to fail silently in the output channel, but vscode introduced a new retry and notification for this. in previous versions of vscode, the server exited non-0, but this didn't cause notifications for the user. this should introduce bugfixes and improvements for non-vscode users of the LSP server as well.
would like to provide more helpful graphql config DX in the future but this should be better for now.
if your LSP server cli implementation needs a non-zero exit for missing/invalid lsp config, let me know and we can add a feature to enable a non-zero failure on config errors for LSP and/or the CLI service wrapper