Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run release script if specified for non npm releases #2481

Merged
merged 1 commit into from
Jun 5, 2022
Merged

Conversation

acao
Copy link
Member

@acao acao commented Jun 5, 2022

I also made a change to the LSP server to make sure we see releases in tandem.

It removes dotenv from the LSP server itself, as the docs now reccomend requiring it in-file

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2022

🦋 Changeset detected

Latest commit: fcdbd5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphql-language-service-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

graphql-language-service-cli@3.2.26-canary-500eef41.0
graphql-language-service-server@2.7.25-canary-500eef41.0

@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #2481 (fcdbd5b) into main (2d91916) will increase coverage by 2.52%.
The diff coverage is 26.34%.

@@            Coverage Diff             @@
##             main    #2481      +/-   ##
==========================================
+ Coverage   65.70%   68.23%   +2.52%     
==========================================
  Files          85       70      -15     
  Lines        5106     4130     -976     
  Branches     1631     1396     -235     
==========================================
- Hits         3355     2818     -537     
+ Misses       1747     1308     -439     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2401b32...fcdbd5b. Read the comment docs.

@acao acao merged commit cf092f5 into main Jun 5, 2022
@acao acao deleted the non-npm-releases branch June 5, 2022 07:48
@acao acao mentioned this pull request Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant