Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add definition support for operation fields #2486

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

stonexer
Copy link
Collaborator

@stonexer stonexer commented Jun 8, 2022

Related to #2472

  • Goto definition for operation fields
definition-for-fields.mp4

@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2022

🦋 Changeset detected

Latest commit: 18dc42f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
graphql-language-service-cli Patch
graphql-language-service-server Patch
graphql-language-service Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #2486 (18dc42f) into main (2d91916) will increase coverage by 2.72%.
The diff coverage is 26.34%.

@@            Coverage Diff             @@
##             main    #2486      +/-   ##
==========================================
+ Coverage   65.70%   68.42%   +2.72%     
==========================================
  Files          85       70      -15     
  Lines        5106     4165     -941     
  Branches     1631     1403     -228     
==========================================
- Hits         3355     2850     -505     
+ Misses       1747     1311     -436     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5278625...18dc42f. Read the comment docs.

@acao
Copy link
Member

acao commented Jun 8, 2022

Wonderful! Can't wait to try this out!!!

@acao
Copy link
Member

acao commented Jun 8, 2022

@cshaver before long we can bring this to monaco-graphql !!! 😍

@acao
Copy link
Member

acao commented Jun 8, 2022

Here is a manually generated "deploy preview"! :)

vscode-graphql-0.4.11.vsix.gz

@acao
Copy link
Member

acao commented Jun 9, 2022

@stonexer tested locally, working great for me!

@acao acao merged commit c9c51b8 into graphql:main Jun 9, 2022
@acao acao mentioned this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants