DisablefillLeafsOnComplete by default
#2488
Conversation
🦋 Changeset detectedLatest commit: e385cc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest changes of this PR are available as canary in npm (based on the declared |
acao
force-pushed
the
fill-leafs-opt-in
branch
2 times, most recently
from
a408a27
to
c79248b
Compare
|
Bah, forgot I need to change a bunch of tests |
|
@stonexer what do you think - updating these tests with minor changes to the language service are cumbersome to the point that I wonder if snapshot tests would be more ideal sometimes? the snapshot diffs would tell us everything we need to know about the changes. and then i could remove the boilerplate for asserting the expected output |
|
I also think the snapshot test might be more efficient on the language service. And we can be a little more detailed when we review the snapshot diff. |
acao
force-pushed
the
fill-leafs-opt-in
branch
from
c79248b
to
019797d
Compare
acao
force-pushed
the
fill-leafs-opt-in
branch
2 times, most recently
from
f456264
to
21f65dc
Compare
Users found this generally annoying by default, especially when there are required arguments Without automatically prompting autocompletion of required arguments as well as lead expansion, it makes the extension harder to use You can now supply this in your graphql config: `config.extensions.languageService.fillLeafsOnComplete` Setting it to to `true` will enable this feature. Will soon add the ability to manually enable this in `monaco-graphql` as well. For both, this kind of behavior would be better as a keyboard command, context menu item &/or codelens prompt
acao
force-pushed
the
fill-leafs-opt-in
branch
from
701bf11
to
e385cc0
Compare
|
@jonathanawesome you'll be pleased to see this bug fixed I'm sure, haha
|
Users found this generally annoying by default, especially when there are required arguments
Fixes #2121
Without automatically prompting autocompletion of required arguments as well as lead expansion, it makes the extension harder to use
You can now supply this in your graphql config:
config.extensions.languageService.fillLeafsOnCompleteSetting it to to
truewill enable this feature.Will soon add the ability to manually enable this in
monaco-graphqlas well.For both, this kind of behavior would be better as a keyboard command, context menu item &/or codelens prompt. We could even re-create the graphiql behavior for this, where after choosing an autocomplete item,
CMD+returnwill automatically fill leaf fields