Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce multi-root workspaces support #2616

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

acao
Copy link
Member

@acao acao commented Aug 1, 2022

A true revert-revert thanks to my shoegun merge 😆

thank you @Foo-x for your patience and understanding, not to mention your contributions!

reverts the revert PR #2612

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2022

🦋 Changeset detected

Latest commit: 9306f66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
vscode-graphql Patch
graphql-language-service-server Patch
graphql-language-service-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

graphql-language-service-cli@3.3.5-canary-8fbd0032.0
graphql-language-service-server@2.8.5-canary-8fbd0032.0

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Base: 65.70% // Head: 69.61% // Increases project coverage by +3.90% 🎉

Coverage data is based on head (73d6f68) compared to base (2d91916).
Patch coverage: 23.84% of modified lines in pull request are covered.

❗ Current head 73d6f68 differs from pull request most recent head 9306f66. Consider uploading reports for the commit 9306f66 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2616      +/-   ##
==========================================
+ Coverage   65.70%   69.61%   +3.90%     
==========================================
  Files          85       72      -13     
  Lines        5106     4275     -831     
  Branches     1631     1436     -195     
==========================================
- Hits         3355     2976     -379     
+ Misses       1747     1294     -453     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.66% <5.66%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 47.61% <66.66%> (+0.63%) ⬆️
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 100 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@acao
Copy link
Member Author

acao commented Aug 2, 2022

I will be ready to take a closer review of this tomorrow night, or perhaps tonight, I think there are a few small tweaks we should make. So much to juggle but this one is going to be big!

@acao acao changed the title Revert "Revert "feat: support vscode multi-root workspaces (#2594)"" 😆 Introduce multi-root workspaces support Sep 3, 2022
@acao
Copy link
Member Author

acao commented Sep 3, 2022

@Foo-x did you have a fix for feature support in SDL files that had to do with document version by chance? or something else that fixes SDL files support in this PR

@Foo-x
Copy link
Contributor

Foo-x commented Sep 3, 2022

@acao
No, I didn't. I don't have any other changes than the PRs I created.

@acao acao force-pushed the revert-2612-revert-multi-root branch from 73d6f68 to 9306f66 Compare October 8, 2022 23:09
@acao
Copy link
Member Author

acao commented Oct 8, 2022

@Foo-x just rebased it and everything is looking great. We re-released the inline operation executor, so now I'm excited to add support for workspaces! more tests and docs can follow, this is already such a great improvement!

@acao acao merged commit b0d7f06 into main Oct 10, 2022
@acao acao deleted the revert-2612-revert-multi-root branch October 10, 2022 19:34
@acao acao mentioned this pull request Oct 10, 2022
@acao acao restored the revert-2612-revert-multi-root branch October 16, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants