Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix TypeScript GraphQL config file loading." #2664

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

acao
Copy link
Member

@acao acao commented Aug 11, 2022

Reverts the bugfix #2658 to fix #2662, a repeat of the bug from last week that it seemed #2658 had introduced. This will break things for graphql.config.ts users again, but make the extension work for more users again

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2022

🦋 Changeset detected

Latest commit: 810f391

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
graphql-language-service-server Patch
vscode-graphql Patch
graphql-language-service-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

graphql-language-service-cli@3.3.3-canary-b2565cf9.0
graphql-language-service-server@2.8.3-canary-b2565cf9.0

@acao
Copy link
Member Author

acao commented Aug 11, 2022

ah... and because the versions aren't pinned, this revert may not even work 😢

@acao
Copy link
Member Author

acao commented Aug 11, 2022

ah the beautiful red squigglies, we're golden

@acao acao force-pushed the revert-2658-chore/upgrade-ts-node branch from 66353ef to 810f391 Compare August 11, 2022 22:28
@acao acao merged commit 721425b into main Aug 11, 2022
@acao acao deleted the revert-2658-chore/upgrade-ts-node branch August 11, 2022 22:36
@acao acao mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode-graphql language service server fails to start after extension update
1 participant