Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(@graphiql/plugin-code-exporter): Fix Typo #2864

Merged
merged 2 commits into from Nov 10, 2022
Merged

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Nov 4, 2022

Small typo fix in the README

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2022

🦋 Changeset detected

Latest commit: fe679ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphiql/plugin-code-exporter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@thomasheyenbrock thomasheyenbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Just a nit about changeset

"@graphiql/plugin-code-exporter": patch
---

chore(@graphiql/plugin-code-exporter): Fix Typo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it's just the README, we don't need a changeset for that (we don't need to publish a new version just because of a typo 😅 )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But otherwise people reading the README on npm won’t get the update

Copy link
Member

@acao acao Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point @LekoArts - especially because it's currently a standalone workspace, it won't get another release until there's another changeset to just this plugin. it seems excessive but I understand why from a release tooling automation standpoint

@acao acao dismissed thomasheyenbrock’s stale review November 10, 2022 23:15

I think it's fair to consider a code example typo to be necessary for a patch release for sure. Maybe small spelling issue elsewhere in the docs, but a broken link or broken example should necessitate a patch release for npm and other registries

@acao
Copy link
Member

acao commented Nov 10, 2022

thank you @LekoArts !

@acao acao merged commit f61a557 into graphql:main Nov 10, 2022
@acao acao mentioned this pull request Nov 10, 2022
@LekoArts LekoArts deleted the patch-1 branch November 11, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants