Do not show dropdown for execute button if an operation is currently running #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f889d7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simhnna
force-pushed
the
do-not-show-dropdown-for-stop
branch
from
8ee94be
to
f889d7d
Compare
acao
reviewed
Nov 10, 2022
| '@graphiql/react': patch | ||
| --- | ||
|
|
||
| Fix stop execution button showing a dropdown |
There was a problem hiding this comment.
Suggested change
| Fix stop execution button showing a dropdown | |
| Bugfix: Stop execution button from showing a dropdown during operation fetch |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have multiple operations defined in the editor, clicking the execute button will show a dropdown to choose which operation to run.
If an operation is running, the stop button still shows the dropdown. Since only one operation can be running at any point in time, showing the dropdown is useless. This merge request makes sure that the dropdown is only shown, if no operation is currently running