Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql-language-service-server): allow getDefinition to work for unions #3150

Merged
merged 5 commits into from
May 6, 2023
Merged

Conversation

AaronMoat
Copy link
Contributor

@AaronMoat AaronMoat commented Apr 25, 2023

Fixes: #2575

Fixes the issue where a schema like

union X = A | B
type A { x: String }
type B { x: String }
type Query { a: X }

won't allow you to click through to X.

Also fixes the case where this is split across two files (e.g. type Query { a: X } is in one file and the rest are in another)

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2023

🦋 Changeset detected

Latest commit: ded2d72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
graphql-language-service-server Patch
graphql-language-service Patch
graphql-language-service-cli Patch
vscode-graphql Patch
cm6-graphql Patch
codemirror-graphql Patch
@graphiql/react Patch
graphiql Patch
monaco-graphql Patch
@graphiql/plugin-explorer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 25, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@AaronMoat
Copy link
Contributor Author

@acao this might be one in your area of interest? :)

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@AaronMoat AaronMoat requested a review from TallTed May 6, 2023 10:13
@acao
Copy link
Member

acao commented May 6, 2023

thank you @AaronMoat ! this is a very helpful improvement

@acao acao merged commit 1d60e9a into graphql:main May 6, 2023
10 checks passed
@acao
Copy link
Member

acao commented May 6, 2023

@AaronMoat this improvement will be reflected in monaco-graphql and graphiql@3 when we introduce definitions as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Go to definition support for union
3 participants