Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installable PWA w/ simple server management plugin #3380

Merged
merged 12 commits into from
Aug 12, 2023
Merged

Installable PWA w/ simple server management plugin #3380

merged 12 commits into from
Aug 12, 2023

Conversation

acao
Copy link
Member

@acao acao commented Jul 31, 2023

In the interest of playground parity, this would be an installable, auto-updating replacement for the electron build

Because we deploy the webpack example build with netlify again, we can just go ahead and make it an installable PWA

image

Demo:

https://deploy-preview-3380--graphiql-test.netlify.app/webpack

click "install" in the URL bar on chrome

Additional Features

  • simple example SelectServer plugin that allows you to provide a graphql server, saves previously requested URLs and shows schema state
  • working copy as cURL using the code-exporter plugin

@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2023

⚠️ No Changeset found

Latest commit: dfe0247

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for graphiql-test ready!

Name Link
🔨 Latest commit fbcf78a
🔍 Latest deploy log https://app.netlify.com/sites/graphiql-test/deploys/64ca229991010200086d32cf
😎 Deploy Preview https://deploy-preview-3380--graphiql-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@acao acao changed the title follow google instructions for installable PWA Installable PWA w/ extremely simple server management plugin Jul 31, 2023
@acao acao changed the title Installable PWA w/ extremely simple server management plugin Installable PWA w/ simple server management plugin Jul 31, 2023
Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor human-facing fixes

examples/graphiql-webpack/README.md Outdated Show resolved Hide resolved
examples/graphiql-webpack/src/index.jsx Outdated Show resolved Hide resolved
examples/graphiql-webpack/webpack.config.js Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@acao acao merged commit 46aa56e into main Aug 12, 2023
2 of 3 checks passed
@acao acao deleted the pwa-example branch August 12, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants