Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily revert svelte parsing until we can fix bundling issues #3503

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

acao
Copy link
Member

@acao acao commented Jan 13, 2024

Temporarily revert svelte parsing until we can fix bundling issues with svelte2tsx. For now we return to using the vue parser to parse svelte files which will invariably cause some issues, such as being off by several characters

Copy link

changeset-bot bot commented Jan 13, 2024

🦋 Changeset detected

Latest commit: 22c144e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
graphql-language-service-server Patch
vscode-graphql Patch
graphql-language-service-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f5ade68) 55.85% compared to head (22c144e) 55.94%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3503      +/-   ##
==========================================
+ Coverage   55.85%   55.94%   +0.08%     
==========================================
  Files         114      113       -1     
  Lines        5303     5291      -12     
  Branches     1441     1441              
==========================================
- Hits         2962     2960       -2     
+ Misses       1911     1903       -8     
+ Partials      430      428       -2     
Files Coverage Δ
...hql-language-service-server/src/findGraphQLTags.ts 82.71% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

The latest changes of this PR are available as canary in npm (based on the declared changesets):

graphql-language-service-cli@3.3.32-canary-8ff51d17.0
graphql-language-service-server@2.11.10-canary-8ff51d17.0

@acao acao merged commit 6c7adf8 into main Jan 13, 2024
14 checks passed
@acao acao deleted the revert-svelte branch January 13, 2024 11:11
@acao acao mentioned this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant