Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block strings syntax highlighting in cm6-graphql #3505

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

Gasser-Aly
Copy link
Contributor

@Gasser-Aly Gasser-Aly commented Jan 14, 2024

This PR fixes and issue where block strings aren't properly highlighted when they containe a new due to how their ANTLR grammar is defined in cm6-graphql

before:

2024-01-15.10-20-00.mp4

after:

2024-01-15.10-21-04.mp4

Copy link

changeset-bot bot commented Jan 14, 2024

🦋 Changeset detected

Latest commit: df8a318

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
cm6-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

linux-foundation-easycla bot commented Jan 14, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@Gasser-Aly Gasser-Aly force-pushed the gasser/fix-triple-quotes branch 2 times, most recently from 6ed30a6 to 647ee31 Compare January 14, 2024 18:47
@Gasser-Aly Gasser-Aly changed the title wip fix: block strings syntax highlighting in cm6-graphql Jan 14, 2024
@Gasser-Aly Gasser-Aly marked this pull request as ready for review January 15, 2024 15:28
@acao
Copy link
Member

acao commented Jan 16, 2024

awesome thank you! @Gasser-Aly can you sign the CLA too? make sure it's with the same email as the one you signed your git commits with

@Gasser-Aly
Copy link
Contributor Author

@acao Signed! Thank you!

@acao acao merged commit a562c96 into graphql:main Jan 24, 2024
13 checks passed
@acao acao mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants