Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexer] Block string does not advance line #1636

Closed
langpavel opened this issue Dec 28, 2018 · 0 comments · Fixed by #1637
Closed

[lexer] Block string does not advance line #1636

langpavel opened this issue Dec 28, 2018 · 0 comments · Fixed by #1637

Comments

@langpavel
Copy link
Contributor

Lexer does not advance line number when tokenizing block strings.

Line numbers are then shifted on all following tokens
langpavel added a commit to langpavel/graphql-js that referenced this issue Dec 28, 2018
@langpavel
fix(lexer): advance line, update lineStart inside block string
a44dcf8 
fix graphql#1636
@langpavel langpavel mentioned this issue Dec 28, 2018
Merged
IvanGoncharov pushed a commit that referenced this issue Dec 31, 2018
@langpavel @IvanGoncharov
Fix: Handle new lines inside block string correctly (#1637)
42db579 
* test(lexer): test if lexer advance line after block string

* fix(lexer): advance line, update lineStart inside block string

fix #1636

* test(lexer): more multiline block string cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Handle new lines inside block string correctly langpavel/graphql-js
1 participant
@langpavel