Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2089 makes a breaking change to field config behavior #2114

Closed
taion opened this issue Aug 23, 2019 · 1 comment · Fixed by #2116
Closed

#2089 makes a breaking change to field config behavior #2114

taion opened this issue Aug 23, 2019 · 1 comment · Fixed by #2116
Labels

Comments

@taion
Copy link
Contributor

taion commented Aug 23, 2019

By no longer passing through other unknown properties to field configurations, #2089 introduces a small breaking change to behavior.

Previously, integrations like https://github.com/4Catalyzer/graphql-validation-complexity#usage could enable additional field configuration just by specifying other fields. Now, against 14.5.0, this no longer works.

It would be great if we could temporarily revert this change, then increment the major version to v15 to make this change.

@taion
Copy link
Contributor Author

taion commented Aug 23, 2019

@IvanGoncharov With respect to #2089 (comment), I very much agree that this change should be made. It's just that, for the sake of compatibility, I don't think this should happen on a non-major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants