Move schema validation into separate step (type constructors) #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
force-pushed
the
validate-schema-types
branch
6 times, most recently
from
290f721
to
8346edb
Compare
leebyron
changed the title
leebyron
force-pushed
the
validate-schema-types
branch
2 times, most recently
from
ab6dde0
to
5b2b39e
Compare
This is the second step of moving work from type constructors to the schema validation function.
leebyron
force-pushed
the
validate-schema-types
branch
from
5b2b39e
to
78099c5
Compare
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second step of moving work from type constructors to the schema validation function.
Currently the implementation should be nearly complete, however there are a lot of tests to migration from expecting throwing exceptions to instead creating validation errors.
Closes #546
Closes #1080
Improves #1079
Improves #719