Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWAPI example: construct schema from SDL #1384

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

SWAPI example: construct schema from SDL #1384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f27fed
Switch SW API example to SDL
IvanGoncharov Mar 5, 2018
9d37803
Use getter function
IvanGoncharov Jun 11, 2018
eef0878
Add hack to path enum with values
IvanGoncharov Jun 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 7 additions & 20 deletions src/__tests__/starWarsData.js
View file
Open in desktop
Expand Up @@ -93,14 +93,9 @@ const droidData = {
* These are Flow types which correspond to the schema.
* They represent the shape of the data visited during field resolution.
*/
export type Character = {
id: string,
name: string,
friends: Array<string>,
appearsIn: Array<number>,
};
export type CharacterData = HumanData | DroidData;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer without the Data suffix for readability

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No please, because of:

graphql-js/src/__tests__/starWarsSchema.js

Line 12 in eef0878

import type { CharacterData, HumanData, DroidData } from './starWarsData';


export type Human = {
export type HumanData = {
type: 'Human',
id: string,
name: string,
Expand All @@ -109,7 +104,7 @@ export type Human = {
homePlanet: string,
};

export type Droid = {
export type DroidData = {
type: 'Droid',
id: string,
name: string,
Expand All @@ -121,23 +116,15 @@ export type Droid = {
/**
* Helper function to get a character by ID.
*/
function getCharacter(id) {
export function getCharacter(id: string): Promise<CharacterData> {
// Returning a promise just to illustrate GraphQL.js's support.
return Promise.resolve(humanData[id] || droidData[id]);
}

/**
* Allows us to query for a character's friends.
*/
export function getFriends(character: Character): Array<Promise<Character>> {
// Notice that GraphQL accepts Arrays of Promises.
return character.friends.map(id => getCharacter(id));
}

/**
* Allows us to fetch the undisputed hero of the Star Wars trilogy, R2-D2.
*/
export function getHero(episode: number): Character {
export function getHero(episode: number): CharacterData {
if (episode === 5) {
// Luke is the hero of Episode V.
return luke;
Expand All @@ -149,13 +136,13 @@ export function getHero(episode: number): Character {
/**
* Allows us to query for the human with the given id.
*/
export function getHuman(id: string): Human {
export function getHuman(id: string): HumanData {
return humanData[id];
}

/**
* Allows us to query for the droid with the given id.
*/
export function getDroid(id: string): Droid {
export function getDroid(id: string): DroidData {
return droidData[id];
}