-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing ESLint rules as comments #1503
Conversation
No changes to existing rules I just sorted them in the same order as official docs. |
So anything that's commented out we want to have on, but we haven't turned it on yet? Any of those that can't be automatically turned on would be great to have as "simple first contribution" tasks for anyone looking to start contributing to the repo. I think the re-order should be a separate PR: that way, it's clear in this PR which rules we want to add, and we can discuss whether those additions are valuable, before encouraging people to modify the repo to get those rules passing. |
3634ca2
to
29537d5
Compare
No, it's just all rules that were added in ESLint. Idea is to keep existing practice of explicitly marking rules as I extracted separate PR with rearrangements: #1511 |
.eslintrc.yml
Outdated
# `eslint-plugin-flowtype` rule list based on `v2.50.0` | ||
# https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype | ||
|
||
#flowtype/array-style-complex-type: undecided |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjmahone now all new rules are marked as undecided
to prevent confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding all of these!
.eslintrc.yml
Outdated
# `eslint-plugin-flowtype` rule list based on `v2.50.0` | ||
# https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype | ||
|
||
#flowtype/array-style-complex-type: undecided |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you
Context: #1503 (comment) > I think the re-order should be a separate PR: that way, it's clear in this PR which rules we want to add,
Idea is to first add all of them as comment and than enable on per rule basis.
29537d5
to
cd542d7
Compare
Note that any of these that deal with formatting (most of the flow ones) should be explicitly off if we're going to use prettier |
@leebyron Thanks for the info 👍 |
Idea is to first add all of them as comment and than enable on per rule
basis.