Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark: always assume schema is valid #1510

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Benchmark: always assume schema is valid #1510

merged 1 commit into from
Sep 6, 2018

Conversation

IvanGoncharov
Copy link
Member

We measure SDL validation separately so it shouldn't affect benchmarks that measure schema build time.

mjmahone
mjmahone approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@mjmahone mjmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@IvanGoncharov IvanGoncharov merged commit 6963fc8 into graphql:master Sep 6, 2018
@IvanGoncharov IvanGoncharov deleted the benchmarkAssumeValidSchema branch September 6, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjmahone mjmahone mjmahone approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IvanGoncharov @mjmahone @facebook-github-bot