Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for missing required argument in field or directive #1554

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Improve error message for missing required argument in field or directive #1554

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46f2e1b
add missing commas to the validator messages
everdimension Oct 15, 2018
1765de8
Switched to 'was' variant
IvanGoncharov Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/validation/rules/ProvidedRequiredArguments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function missingFieldArgMessage(
): string {
return (
`Field "${fieldName}" argument "${argName}" of type ` +
`"${type}" is required but not provided.`
`"${type}" is required, but it was not provided.`
);
}

Expand All @@ -38,7 +38,7 @@ export function missingDirectiveArgMessage(
): string {
return (
`Directive "@${directiveName}" argument "${argName}" of type ` +
`"${type}" is required but not provided.`
`"${type}" is required, but it was not provided.`
);
}

Expand Down