New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASTValidation covers all validation rules that do not use Schema #1568

Merged

mjmahone merged 1 commit into master from more-ast-visitor

Dec 1, 2018

Contributor

mjmahone commented Nov 6, 2018

There are at least two different classes of validation rules:

Validation that requires Schema information (e.g. KnownTypeNames)
Validation that does not require any Schema information (e.g. `NoFragmentCycles)

This makes sure NoFragmentCycles and NoUnusedFragments can use the ASTValidation, as neither of these rules need schema information.


          ASTValidation covers all validation rules that do not use Schema

b4a5f41

facebook-github-bot added the CLA Signed label

mjmahone requested a review from IvanGoncharov

November 20, 2018 18:50

IvanGoncharov approved these changes

View reviewed changes

Member

IvanGoncharov left a comment

@mjmahone Sorry, completely forget about this PR.
Great improvement 👍

mjmahone merged commit 93efa96 into master

IvanGoncharov deleted the more-ast-visitor branch

January 2, 2019 19:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment