Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OverlappingFieldsCanBeMerged: remove excessive caching #2352

Merged
merged 1 commit into from Jan 15, 2020
Merged

OverlappingFieldsCanBeMerged: remove excessive caching #2352

merged 1 commit into from Jan 15, 2020

Conversation

IvanGoncharov
Copy link
Member

This caching is unneeded since fragment names are always collected into
map and does contains duplicates, see:

graphql-js/src/validation/rules/OverlappingFieldsCanBeMerged.js

Line 711 in 6c377ac

cached = [nodeAndDefs, Object.keys(fragmentNames)];

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jan 15, 2020
@IvanGoncharov IvanGoncharov merged commit 8c7fe9d into graphql:master Jan 15, 2020
@IvanGoncharov IvanGoncharov deleted the pr_branch branch January 15, 2020 08:59
@snyk-bot snyk-bot mentioned this pull request Feb 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@IvanGoncharov