Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve defaultValue literals #3074

Open
wants to merge 1 commit into
base: coerce-input-literal
Choose a base branch
from

Commits on Jun 3, 2021

  1. Preserve defaultValue literals

    Fixes #3051
    
    This change solves the problem of default values defined via SDL not always resolving correctly through introspection by preserving the original GraphQL literal in the schema definition. This changes argument and input field definitions `defaultValue` field from just the "value" to a new `GraphQLDefaultValueUsage` type which contains either or both "value" and "literal" fields.
    
    Since either of these fields may be set, new functions for resolving a value or literal from either have been added - `getLiteralDefaultValue` and `getCoercedDefaultValue` - these replace uses that either assumed a set value or were manually converting a value back to a literal.
    
    Here is the flow for how a default value defined in an SDL would be converted into a functional schema and back to an SDL:
    
    **Before this change:**
    
    ```
    (SDL) --parse-> (AST) --coerceInputLiteral--> (defaultValue config) --valueToAST--> (AST) --print --> (SDL)
    ```
    
    `coerceInputLiteral` performs coercion which is a one-way function, and `valueToAST` is unsafe and set to be deprecated in #3049.
    
    **After this change:**
    
    ```
    (SDL) --parse-> (defaultValue literal config) --print --> (SDL)
    ```
    leebyron committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    f1a14c6 View commit details
    Browse the repository at this point in the history