TS: Fix strict issues in src/error #3142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
commented
May 27, 2021
Comment on lines
-17
to
-24
| /** | ||
| * A message describing the Error for debugging purposes. | ||
| * | ||
| * Enumerable, and appears in the result of JSON.stringify(). | ||
| * | ||
| * Note: should be treated as readonly, despite invariant usage. | ||
| */ | ||
| message: string; |
There was a problem hiding this comment.
Removed this since it's already included via extends Error
Merged
leebyron
force-pushed
the
ts-strict-execution
branch
from
bd7d362
to
627b258
Compare
leebyron
force-pushed
the
ts-strict-execution
branch
from
627b258
to
5083558
Compare
leebyron
force-pushed
the
ts-strict-execution
branch
from
5083558
to
fc1dfa9
Compare
leebyron
force-pushed
the
ts-strict-execution
branch
from
fc1dfa9
to
9ea1273
Compare
leebyron
force-pushed
the
ts-strict-execution
branch
from
9ea1273
to
781e913
Compare
leebyron
force-pushed
the
ts-strict-execution
branch
from
781e913
to
111a481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3141
src/error