Deprecate SubscriptionArgs and broaden ExecutionArgs #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacovCR
changed the title
yaacovCR
force-pushed
the
broaden-execution-args
branch
2 times, most recently
from
d5f133f
to
b92b2b4
Compare
IvanGoncharov
requested changes
Oct 9, 2021
There was a problem hiding this comment.
@yaacovCR Great PR 👍
Happy to merge it once you address all the points I left.
Please re-request review once you fix them.
yaacovCR
force-pushed
the
execute-root-fields
branch
from
04f6bd1
to
9d0a0a1
Compare
yaacovCR
force-pushed
the
broaden-execution-args
branch
from
b92b2b4
to
1b770ad
Compare
yaacovCR
changed the title
yaacovCR
force-pushed
the
execute-root-fields
branch
from
9d0a0a1
to
ea6b79e
Compare
Broaden ExecutionArgs to include all properties within SubscriptionArgs. Retain the SubscriptionArgs type for backwards compatibility, to be removed in the next major version. This allows for better unification of subscription operations alongside queries and mutations as additional targets of execution.
previously, this refactoring changed the `buildExecutionContext` method to store the default subscribeFieldResolver separately from the default fieldResolver within the ExecutionContext -- for clarity. Unfortunately (and ironically!), we still used the fieldResolver property from the ExecutionContext instead of the new subscribeFieldResolver.
yaacovCR
force-pushed
the
broaden-execution-args
branch
from
cfd03aa
to
7ae9bdd
Compare
IvanGoncharov
added
the
PR: feature 🚀
yaacovCR
added a commit
that referenced
this pull request
Oct 11, 2021
yaacovCR
added a commit
that referenced
this pull request
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broaden ExecutionArgs to include all properties within SubscriptionArgs. Retain the SubscriptionArgs type for backwards compatibility, to be removed in the next major version.
This allows for better unification of subscription operations alongside queries and mutations as additional targets of execution.
Depends on #3294