Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add message that we only support TS >= 4.1.0" #3338

Closed
wants to merge 1 commit into from

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Oct 27, 2021

That change imposed an unnecessary restrictions on packages dependant on graphql to use older versions of TS.

Reverts #3319

@yaacovCR
Copy link
Contributor

@IvanGoncharov what is context of original change? I took a look at referenced issue microsoft/TypeScript#44795 — a fix seems in with version 4.5, what is connection to 4.1?

@IvanGoncharov
Copy link
Member

That change imposed an unnecessary restrictions on packages dependant on graphql to use older versions of TS.

@saihaj Without this change users will get a long list (41 errors) of parsing errors:
image

With this change they get
image

The idea behind #3319 was to improve DX and save us from surprised users who will open issues on our repo.

@IvanGoncharov
Copy link
Member

I took a look at referenced issue microsoft/TypeScript#44795 — a fix seems in with version 4.5, what is connection to 4.1?

@yaacovCR Good catch!
I accidentally left the wrong link, correct one was microsoft/TypeScript#32166

what is context of original change?

TS has no mechanism to specify minimally supported versions, moreover, it prints a bunch of parsing errors and that's very confusing behavior especially for inexperienced devs.
For details, please see my previous comment.

@IvanGoncharov
Copy link
Member

@saihaj @yaacovCR I figure out a fix already will post it shortly.

@saihaj
Copy link
Member Author

saihaj commented Oct 27, 2021

TS has no mechanism to specify minimally supported versions

In that case shouldn’t it be greater than some TS version instead of less than?

@IvanGoncharov
Copy link
Member

IvanGoncharov commented Oct 27, 2021

In that case shouldn’t it be greater than some TS version instead of less than?

@saihaj Where did #3319 had "less than"?

@saihaj
Copy link
Member Author

saihaj commented Oct 27, 2021

In that case shouldn’t it be greater than some TS version instead of less than?

@saihaj Where did #3319 had "less than"?

my bad

IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this pull request Oct 27, 2021
@saihaj saihaj closed this Oct 27, 2021
@saihaj saihaj deleted the revert-3319-pr_branch branch October 27, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants