Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse GraphQLWrappingType in 'GraphQLType' definition #3627

Merged
merged 1 commit into from Jun 6, 2022

Conversation

IvanGoncharov
Copy link
Member

Now GraphQLType is union of named types and wrapping types.
Spotted during review of #3622

Now GraphQLType is union of named types and wrapping types.
Spotted during review of graphql#3622
@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jun 6, 2022
@netlify
Copy link

netlify bot commented Jun 6, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 60ec4ee
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/629df4911aa1b5000803c4bf
😎 Deploy Preview https://deploy-preview-3627--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

Copy link
Contributor

@yaacovCR yaacovCR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@IvanGoncharov IvanGoncharov merged commit 385597e into graphql:main Jun 6, 2022
@IvanGoncharov IvanGoncharov deleted the pr_branch2 branch June 6, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants