Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polish: mapAsyncIterator #3696

Merged
merged 2 commits into from Aug 15, 2022
Merged

polish: mapAsyncIterator #3696

merged 2 commits into from Aug 15, 2022

Conversation

yaacovCR
Copy link
Contributor

  1. rename to mapAsyncIterable => to better reflect function argument
  2. use expectPromise in tests

extracted from #3694

@netlify
Copy link

netlify bot commented Aug 14, 2022 •
edited

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit d99b6de
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/62f96400b6c0a30008da3aa3
😎 Deploy Preview https://deploy-preview-3696--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yaacovCR yaacovCR mentioned this pull request Aug 14, 2022
Closed
@github-actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Aug 14, 2022
@yaacovCR yaacovCR requested review from elisatrevino and a team and removed request for elisatrevino August 14, 2022 21:56
IvanGoncharov
IvanGoncharov approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@IvanGoncharov IvanGoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaacovCR Makes a lot of sense 👍

@IvanGoncharov
Copy link
Member

@yaacovCR Please preserve commit during merging:
image

@yaacovCR yaacovCR merged commit 30d51c3 into graphql:main Aug 15, 2022
@yaacovCR yaacovCR deleted the polish-map-async branch August 15, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanGoncharov IvanGoncharov IvanGoncharov approved these changes

Assignees
No one assigned
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yaacovCR @IvanGoncharov