Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQLObjectType: partial revert of #3143, due to perf regression #3874

Merged
merged 1 commit into from Apr 3, 2023

Conversation

IvanGoncharov
Copy link
Member

@IvanGoncharov IvanGoncharov commented Apr 3, 2023

Context: revert back to use bind since it way faster
Reverts: ac70985#diff-abcb97c7918631025353ea7ae5c1913946f00eb9d5d7ea9fe6060b6cfd92d480L761

image

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Apr 3, 2023
@netlify
Copy link

netlify bot commented Apr 3, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit eb606de
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/642ad3e27570050008266503
😎 Deploy Preview https://deploy-preview-3874--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pull_request.yml:codeql. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@IvanGoncharov IvanGoncharov merged commit a68dc42 into graphql:main Apr 3, 2023
22 checks passed
@IvanGoncharov IvanGoncharov deleted the pr_branch branch April 3, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant