Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node v20 for CI #3992

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Use node v20 for CI #3992

merged 1 commit into from
Nov 23, 2023

Conversation

robrichard
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 66f3b67
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/655e47e424235a000819f1c8
😎 Deploy Preview https://deploy-preview-3992--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi @robrichard, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@@ -30,10 +30,10 @@
},
"scripts": {
"preversion": ". ./resources/checkgit.sh && npm ci --ignore-scripts",
"version": "ts-node resources/gen-version.ts && npm test && git add src/version.ts",
"version": "node --loader ts-node/esm resources/gen-version.ts && npm test && git add src/version.ts",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robrichard robrichard marked this pull request as ready for review November 22, 2023 18:46
Copy link
Member

@IvanGoncharov IvanGoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good!
One problem is that it breaks, CI job that diffs packages.
If you can't quickly fix it, then just disable it since it's critical to dev workflow.

@robrichard
Copy link
Contributor Author

robrichard commented Nov 22, 2023

@IvanGoncharov i think the diff check breaks because it’s loading the prior commit which does not have the fixes in this pr.

So I think once this is merged it will start working again

@IvanGoncharov IvanGoncharov merged commit 688ee2f into main Nov 23, 2023
33 of 34 checks passed
@IvanGoncharov IvanGoncharov deleted the robrichard/node20 branch November 23, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants